Some Bitswap Refactoring #140
Conversation
| func standardStrategy(l *ledger) bool { | ||
| return rand.Float64() <= probabilitySend(l.Accounting.Value()) | ||
| r := rand.New(rand.NewSource(1234)) |
There was a problem hiding this comment.
the rand object we instantiate should be stored somewhere, possibily in the ledger. and should be constructed when the ledger is created.
There was a problem hiding this comment.
Also, the seed should be seeded by time, (or a random number from crypto/rand)
There was a problem hiding this comment.
@llSourcell ... why did you introduce a constant seed? This is wrong. rand.Float64 will draw from the default source, which we can initialize with a random seed using rand.Seed.
|
@llSourcell this PR introduces two changes which are incorrect. The rest is just moving code around in a single file, which is not actually useful. Go goes to great lengths to make code position in files a non-issue. (Specifying a canonical style + Sorry @llSourcell, but this kind of PR is another that has mainly wasted your and our time. :( I really appreciate your willingness and effort to help IPFS. But please familiarize yourself more with Go and the systems at hand (like 👍 thanks, and sorry! |
This PR Includes
-making a clarifying comment on why we are currently using AlwaysSendtoPeer as a BS strategy
-re-ordering functions so that types are above functions (looks cleaner)
-There was a TODO regarding using float64 in the strategy that could've resulted in a lock, avoiding the lock
-We were using nice as a word for how we view other peers, changed that to 'trusted'. We want to bitswap to be an auction that involves trust-the strategy should vary based on how trustworthy we are, and how much we trust the peer.